Re: svn commit: r30811 - branches/1.5.x

On Mon, Apr 28, 2008 at 8:28 AM, Kamesh Jayachandran <kamesh_at_collab.net> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
>
>
> Hyrum K. Wright wrote:
>
> > Kamesh Jayachandran wrote:
> >>
> >>
> >> Hyrum K. Wright wrote:
> >>> arfrever_at_tigris.org wrote:
> >>> > * Apply patch at,
> >>>> http://subversion.tigris.org/servlets/ReadMsg?list=dev&msgNo=137828
> >>>> Fixes compiler warning, which has been introduced while
> >>>> resolving the
> >>>> conflict from merge of r30633 from trunk.
> >>>> Votes: - +1 kameshj
> >>>> + +1 kameshj, arfrever
> >>> Hmmm. Instead of voting to apply the patch at that address, perhaps we
> >>> should create a branch, apply the patch to the branch, and then vote on
> >>> the branch? It seems a bit easier for people to review, and a bit more
> >>> inline with our process. Of course, if we want to change the process,
> >>> that's fine, too. :)
> >>
>
> I agree with you. But we should have 'exceptions to our rule' for
> trivial stuff like this one.

+1

--dave

-- 
David Glasser | glasser@davidglasser.net | http://www.davidglasser.net/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org