Re: svn commit: r30685 - branches/svnserve-logging/subversion/svnserve

On Mon, Apr 28, 2008 at 01:37:35PM -0700, epg_at_google.com wrote:
> I suppose the lack of response means this has already been
> reviewed, isn't going to be reviewed, or may get more attention
> on trunk ;->. I'll commit today or tomorrow, and then commit
> some error logging changes I have pending.

I looked over the diff very briefly, but for lack of time didn't
look through it as thoroughly as I was planning to.

I didn't want to send a mail pointing out the single thing I noticed
while skimming over it, but now that you're gonna merge anyway,
and before it gets lost:

Index: subversion/libsvn_subr/log.c
===================================================================
--- subversion/libsvn_subr/log.c (.../trunk) (revision 0)
+++ subversion/libsvn_subr/log.c (.../branches/svnserve-logging) (revision 30692)
@@ -0,0 +1,379 @@
+/*
+ * serve.c : Functions for serving the Subversion protocol
    ^^^^^^^

Should be log.c, right?

-- 
Stefan Sperling <stsp_at_elego.de>                    Software Monkey
 
German law requires the following banner :(
elego Software Solutions GmbH                            HRB 77719
Gustav-Meyer-Allee 25, Gebaeude 12        Tel:  +49 30 23 45 86 96 
13355 Berlin                              Fax:  +49 30 23 45 86 95
http://www.elego.de                               CEO: Olaf Wagner
 
Store password unencrypted (yes/no)? No