Re: [PATCH] validate MIME type correctly

On Mon, Apr 28, 2008 at 06:33:20PM +0300, Daniel Shahaf wrote:
> Stefan Sperling wrote on Mon, 28 Apr 2008 at 17:00 +0200:
> > On Mon, Apr 28, 2008 at 10:31:58AM -0400, C. Michael Pilato wrote:
> > > $ svn pget svn:mime-type ~/projects/subversion/COMMITTERS
> > > text/plain; charset=UTF-8
> >
> > Btw, if there's any space before the semicolon (i.e. 'text/plain ;')
> > trunk will now raise an error. RFC 1521 seems to agree with this:
> >
> > content := "Content-Type" ":" type "/" subtype *(";" parameter)
> > subtype := token
> > token := 1*<any (ASCII) CHAR except SPACE, CTLs, or tspecials>
> >
> > But I hope we're not breaking anyone's setup.
> >
> >
>
> Why is a space allowed *after* the semicolon (as in cmpilato's example)?
>
> The definition of 'parameter' doesn't seem to allow whitespace:
>
> content := "Content-Type" ":" type "/" subtype *(";" parameter)
> parameter := attribute "=" value
> attribute := token ; case-insensitive
> value := token / quoted-string
> token := 1*<any (ASCII) CHAR except SPACE, CTLs, or tspecials>

Hmmm. Well, that's probably an error in the RFC. Note that in the RFC
itself they are providing a few examples that exactly match cmpilato's
example. I couldn't find anything in the RFC indicating that
"plain/text ;charset=UTF-8" is valid.

-- 
Stefan Sperling <stsp_at_elego.de>                    Software Monkey
 
German law requires the following banner :(
elego Software Solutions GmbH                            HRB 77719
Gustav-Meyer-Allee 25, Gebaeude 12        Tel:  +49 30 23 45 86 96 
13355 Berlin                              Fax:  +49 30 23 45 86 95
http://www.elego.de                               CEO: Olaf Wagner
 
Store password unencrypted (yes/no)? No