Re: [PATCH] svnsync init URL1 URL1

On Sun, Apr 27, 2008 at 10:38 PM, Daniel Shahaf <d.s_at_daniel.shahaf.co.il> wrote:
> David Glasser wrote on Sun, 27 Apr 2008 at 13:31 -0700:
>
> > 2008/4/27 Daniel Shahaf <d.s_at_daniel.shahaf.co.il>:
> > > I discovered today by accident that trunk svnsync doesn't care if the
> > > source and destination are the same:
> > >
> > > > svnsync init file:///tmp/repos file:///tmp/repos
> > > Copied properties for revision 0 (svn:sync-* properties skipped).
> > >
> > > This patch changes it to notice that:
> > >
> > > > svnsync init file:///tmp/repos file:///tmp/repos
> > > ..\..\..\subversion\svnsync\main.c:632: (apr_err=195012)
> > > svnsync: Cannot sync a repository to another with the same UUID
> >
> > I think the real use cases that this prevents are important, and this
> > would just add another step of hassle.
> >
>
> OK. (The hassle can be automated, but you know that.) I hadn't
> considered all possible uses -- I admit that.
>
>
> > Perhaps this check might be reasonable if it's actually a check that:
> >
> > * dest.HEAD == 0 (already done)
> > * dest.uuid == src.uuid (your patch)
> > and
> > * src.HEAD == 0
> >
> > ie, "you're trying to sync from an empty repository to another empty
> > repository with the same UUID; are you sure you entered two different
> > repositories?"
> >
>
> Why src.HEAD == 0? Suppose someone has many svnsync'ed same-UUID
> repositories and creates a new repository. When they create it, they
> might create and init the mirror at the same time -- hitting this check.

Well, I'm confused. What are you actually trying to prevent with the
original check?

--dave

-- 
David Glasser | glasser@davidglasser.net | http://www.davidglasser.net/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org