[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] validate MIME type correctly (was: Re: svn: MIME type 'text/x-c++' ends with non-alphanumeric) character

From: Stefan Sperling <stsp_at_elego.de>
Date: Sat, 26 Apr 2008 17:30:33 +0200

On Sat, Apr 26, 2008 at 02:44:47PM +0200, Alan Barrett wrote:
> On Sat, 26 Apr 2008, Stefan Sperling wrote:
> > > except I am not sure if you want to
> > > allow svn:mime_type="type/subtype ; parameter = value"
> >
> > The code explicitly allows this. I don't know whether this
> > is good/bad, but I don't think we should break this since
> > it's probably being used in the wild somewhere.
>
> Oh, I missed the fact that the new code was focused only on the
> type/subtype part of the string. I think it's good to allow semicolon
> and parameters, but I mistakenly thought that the code would deny them.

OK.

Patch passes make check, comitted in r30795.

-- 
Stefan Sperling <stsp_at_elego.de>                    Software Monkey
 
German law requires the following banner :(
elego Software Solutions GmbH                            HRB 77719
Gustav-Meyer-Allee 25, Gebaeude 12        Tel:  +49 30 23 45 86 96 
13355 Berlin                              Fax:  +49 30 23 45 86 95
http://www.elego.de                               CEO: Olaf Wagner
 
Store password unencrypted (yes/no)? No

  • application/pgp-signature attachment: stored
Received on 2008-04-26 17:30:38 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.