[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [RFC] Target aware commit message processing

From: Daniel Shahaf <d.s_at_daniel.shahaf.co.il>
Date: Thu, 24 Apr 2008 10:14:55 +0300 (Jerusalem Daylight Time)

Justin Erenkrantz wrote on Wed, 23 Apr 2008 at 17:23 -0700:
> However, there are quite common scenarios where we may not be able to
> parse the lines properly. What happens when the log message doesn't
> have the special log lines? What do you do? Do you assume that you
> use the original set or that the user intended to commit nothing?

If the '--This line, and those below, will be ignored--' line is not
present, the former (committing all original targets) seems logical to me.
(I always delete this line and everything below it before committing,
because otherwise there is an annoying trailing EOL in the log message.)

> I can actually see both cases as reasonable interpretations - think of
> the '-F' case but also think of a user who wants to abort a commit
> after starting it and has already saved the log message.

I assumed the magic parsing would be not done to messages given by -F or
-m. In those cases, the special lines are not present in the first place,
so I do not see why they should be parsed. (We are not expecting people
to add the special lines manually, right?)

To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-04-24 09:15:23 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.