[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [RFC] Target aware commit message processing

From: Stefan Sperling <stsp_at_elego.de>
Date: Wed, 23 Apr 2008 23:43:14 +0200

On Tue, Apr 22, 2008 at 09:10:26PM -0500, Troy Curtis Jr wrote:
> I have been thinking about implementing commit message parsing such
> that one can delete unwanted targets out of the commit message listing
> to remove them from the commit (like svk).

I don't know how svk behaves (I've only used it briefly, and liked
it), but does this mean that if I had a commit message like:

  blah blah blah
  --This line, and those below, will be ignored--
  D a
  A b

and I deleted the 'D a' line, the commit would not delete 'a',
effectively ignoring this local modification? And the same would
work for 'A a' and 'M a' lines and such?

Is taking changes out of a commit the only goal here or is
there more to this feature?

> I have implemented a perl
> wrapper script that does this but it has a few issues. I might be
> able to work those issues out (though it isn't really worth it), but I
> definitly would rather have a built-in option.

Do you mean "command line option" or "optional functionality that
is enabled by default?" I mean, I'd rather have this work by default,
cause if I was to take a file out of a changeset while writing a
log message, it would be cumbersome having to exit the editor and
run 'svn ci' again with --parse-my-commit-message-please.

> My question: Who else thinks this would be useful?

It maps a bit of Subclipse's commit file selection dialog
into the CLI, so yeah, why not.

I think Subversion should definitly be informing the user
about changes it's omitting. Something like:

  "svn-commit.tmp" 4L, 60C written
  Some items were removed from the commit message listing,
  omitting them.
  Omitting a
  Adding b
  Transmitting file data .
  Committed revision 1.

Stefan Sperling <stsp_at_elego.de>                    Software Monkey
German law requires the following banner :(
elego Software Solutions GmbH                            HRB 77719
Gustav-Meyer-Allee 25, Gebaeude 12        Tel:  +49 30 23 45 86 96 
13355 Berlin                              Fax:  +49 30 23 45 86 95
http://www.elego.de                               CEO: Olaf Wagner
Store password unencrypted (yes/no)? No

  • application/pgp-signature attachment: stored
Received on 2008-04-23 23:41:54 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.