Daniel Shahaf <d.s_at_daniel.shahaf.co.il> writes:
> Karl Fogel wrote on Tue, 22 Apr 2008 at 23:28 -0000:
>> > *saved = FALSE;
>> >
>> > if (! creds->may_save)
>> > + no_auth_cache = TRUE;
>> > +
>> > + if (no_auth_cache)
>> > return SVN_NO_ERROR;
>>
>> ...why not just fold this condition into the initialization of
>> no_auth_cache in the first place?
>
> Because
>
> apr_hash_get(SVN_AUTH....WHATEVER) != NULL
> || ! creds->may_save
>
> would be very long and would break symmetry with the other initialisations
> nearby.
Well, see r30760 -- it's kind of a matter of taste, but my feeling was
not to try to be the same as the other initializations if the actual
conditions for this one were different, which they are. So I did it all
at once, hopefully in a clear way.
Thanks for the fix!
-Karl
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-04-23 15:47:18 CEST