Re: [PATCH] Username caching

Daniel Shahaf <d.s_at_daniel.shahaf.co.il> writes:
> Karl Fogel wrote on Tue, 22 Apr 2008 at 14:20 -0400:
>> Daniel Shahaf <d.s_at_daniel.shahaf.co.il> writes:
>> > 1. If 'store-passwords' (in ~/.subversion/config) was set to FALSE,
>> > then usernames would not be cached either.
>> >
>> > 2. simple_save_creds_helper only checked CREDS->may_save, but
>> > ignored its SVN_AUTH_PARAM_NO_AUTH_CACHE parameter.
>> > (stsp pointed this out)
>>
>> What was the user-visible manifestation of (2) ?
>>
>
> [ Summary: API violation, cmdline client probably unaffected. ]

Thanks -- got it. Just make sure the log message for the change
clarifies this.

Reviewing patch now.

-K

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-04-22 22:22:08 CEST