[PATCH] Username caching

Attached patch fixes two issues:

    1. If 'store-passwords' (in ~/.subversion/config) was set to FALSE,
       then usernames would not be cached either.
    
    2. simple_save_creds_helper only checked CREDS->may_save, but
       ignored its SVN_AUTH_PARAM_NO_AUTH_CACHE parameter.
       (stsp pointed this out)

I tested manually several combinations of --no-auth-cache,
store-passwords=FALSE and store-auth-creds=FALSE, and they worked. I do
not claim that my manual testing covered all possible situations.

[[[
Username/password caching bugfixes.

* subversion/libsvn_subr/simple_providers.c
  (simple_save_creds_helper):
    Cache the username even if we're not allowed to cache the password,
    and respect SVN_AUTH_PARAM_NO_AUTH_CACHE.

Suggested by: stsp
Patch by: Daniel Shahaf <d.s_at_daniel.shahaf.co.il>
]]]

Thanks,

Daniel

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org