[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

svn commit: r30723, r30730

From: Daniel Shahaf <d.s_at_daniel.shahaf.co.il>
Date: Mon, 21 Apr 2008 20:56:31 +0300

Good morning Stefan,

A few comments on the dont-* branch.

> --- subversion/libsvn_subr/config_file.c (revision 30722)
> +++ subversion/libsvn_subr/config_file.c (revision 30723)
> @@ -793,6 +793,17 @@ svn_config_ensure(const char *config_dir
> + "### on disk unencrypted." NL
> + "###" NL
> + "### store-plaintext-passwords may be either 'yes', 'no', or 'prompt'." NL

This line is 160 characters long.

> @@ -822,12 +833,13 @@ svn_config_ensure(const char *config_dir
> "# http-proxy-port = 9000" NL
> - "# No username and password, so use the defaults below." NL
> + "# No username and password for the proxy, so use the defaults below." NL

So is this one.

> --- subversion/libsvn_subr/prompt.c (revision 30729)
> +++ subversion/libsvn_subr/prompt.c (revision 30731)
> @@ -385,6 +385,7 @@ svn_cmdline_auth_plaintext_prompt(svn_boolean_t *m
> const char *answer = NULL;
> svn_boolean_t answered = FALSE;
> const char *prompt_string = _("Store password unencrypted (yes/no)? ");
> + svn_cmdline_prompt_baton2_t *pb = baton;

The function's docstring should be updated to reflect that @a baton is
now used.

Daniel

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-04-22 08:54:24 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.