Re: [PATCH] svneditor.bat

On Mon, 2008-04-21 at 01:58 -0400, Karl Fogel wrote:
> Mark Reibert <svn_at_reibert.com> writes:
> > On Mon, 2008-04-21 at 01:48 -0400, Karl Fogel wrote:
> >> Daniel Shahaf <d.s_at_daniel.shahaf.co.il> writes:
> >> >
> >> > Index: subversion/tests/cmdline/svneditor.bat
> >> > ===================================================================
> >> > --- subversion/tests/cmdline/svneditor.bat (revision 30700)
> >> > +++ subversion/tests/cmdline/svneditor.bat (working copy)
> >> > @@ -1,5 +1,5 @@
> >> > @echo off
> >> > rem the svneditor.py script is expected to be in the same directory as the
> >> > rem .bat file
> >> > -%~dp0\svneditor.py %*
> >> > +python %~dp0\svneditor.py %*
> >
> > Is it safe to assume python will be in %PATH% ?
>
> Good question. I don't know if there is any connection between:
>
> a) having a ".py" file run automagically on Windows, and
> b) python itself being in %PATH%

I am not much of a Windows guy myself, but as I understand it
associations between file extensions and the binary that "opens" the
file are handled by a registry entry that specifies the full path to the
binary. Option b), on the other hand, seems quite clearly to require
python in %PATH%.

> So possibly, if you're on one of those systems where svneditor.py has
> been invokable all along (i.e., not Daniel's system), then what worked
> fine before this patch would break after it.

My guess it this is quite possible.

> All the more reason to figure out what's going on with Daniel's system
> vs other systems...

Installing python on Windows would, presumably, create the registry
association between .py files and the python interpreter binary. Could
Daniel's system be the first that is missing this association?

-- 
----------------------
Mark S. Reibert, Ph.D.
svn_at_reibert.com
----------------------
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org