Re: svn commit: r30728 - in branches/dont-save-plaintext-passwords-by-default: . subversion/libsvn_subr

Hmm, so "svn whatever --non-interactive --password foo" wouldn't store
passwords even if it is explicitly configured to store them?

--dave

On Mon, Apr 21, 2008 at 3:15 AM, <stsp_at_tigris.org> wrote:
> Author: stsp
> Date: Mon Apr 21 03:15:57 2008
> New Revision: 30728
>
> Log:
> On the dont-save-plaintext-passwords-by-default branch:
>
> * subversion/libsvn_subr/cmdline.c
> (svn_cmdline_setup_auth_baton2): Don't store plaintext passwords
> in non-interactive mode, regardless of what any config files say.
>
> * TODO.branch: Knock off TODO item.
>
> Modified:
> branches/dont-save-plaintext-passwords-by-default/TODO.branch
> branches/dont-save-plaintext-passwords-by-default/subversion/libsvn_subr/cmdline.c
>
> Modified: branches/dont-save-plaintext-passwords-by-default/TODO.branch
> URL: http://svn.collab.net/viewvc/svn/branches/dont-save-plaintext-passwords-by-default/TODO.branch?pathrev=30728&r1=30727&r2=30728
> ==============================================================================
> --- branches/dont-save-plaintext-passwords-by-default/TODO.branch Mon Apr 21 01:42:12 2008 (r30727)
> +++ branches/dont-save-plaintext-passwords-by-default/TODO.branch Mon Apr 21 03:15:57 2008 (r30728)
> @@ -4,5 +4,3 @@ TODO items on this branch:
>
> - During the prompt, tell users where exactly the configuration file is,
> if possible.
> -
> -- Handle the non-interactive case properly.
>
> Modified: branches/dont-save-plaintext-passwords-by-default/subversion/libsvn_subr/cmdline.c
> URL: http://svn.collab.net/viewvc/svn/branches/dont-save-plaintext-passwords-by-default/subversion/libsvn_subr/cmdline.c?pathrev=30728&r1=30727&r2=30728
> ==============================================================================
> --- branches/dont-save-plaintext-passwords-by-default/subversion/libsvn_subr/cmdline.c Mon Apr 21 01:42:12 2008 (r30727)
> +++ branches/dont-save-plaintext-passwords-by-default/subversion/libsvn_subr/cmdline.c Mon Apr 21 03:15:57 2008 (r30728)
> @@ -506,8 +506,8 @@ svn_cmdline_setup_auth_baton2(svn_auth_b
> * try the 'config' file.
> */
>
> - store_plaintext_password_val = NULL;
> - if (urls)
> + store_plaintext_password_val = non_interactive ? SVN_CONFIG_FALSE : NULL;
> + if (urls && ! store_plaintext_password_val)
> {
> /* Check server groups in turn, first match wins. */
> subpool = svn_pool_create(pool);
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: svn-unsubscribe_at_subversion.tigris.org
> For additional commands, e-mail: svn-help_at_subversion.tigris.org
>
>

-- 
David Glasser | glasser@davidglasser.net | http://www.davidglasser.net/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org