[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Use subprocess.Popen for executing commands in cmdline tests

From: Branko ─îibej <brane_at_xbc.nu>
Date: Fri, 18 Apr 2008 14:35:51 +0200

Daniel Shahaf wrote:
> jeremy hinds wrote on Wed, 9 Apr 2008 at 22:49 -0600:
>
>> 2008/4/8 jeremy hinds <jeremy.hinds_at_gmail.com>:
>>
>>> Thanks for clearing that up. While rewriting the patch to handle
>>> universal_newlines and shell=False, another question came up.
>>>
>>> I made universal_newlines apply on any platform rather than just
>>> Windows, and that seemed to work fine on everything except
>>> import_tests.import_eol_style(). The problem is that
>>> run_and_verify_svn() has text mode hard-coded in it, so the "\r\n"
>>> sequences were converted to "\n". (Honestly, I don't understand how
>>> that test worked accurately on Windows before.)
>>>
>>> The question is whether it is better to preserve old behavior by never
>>> using universal_newlines on posix, or should I add a "binary_mode"
>>> parameter to run_and_verify_svn2()?
>>>
>>>
>> I decided err on the side of flexibility and add a "binary_mode" param
>> to run_and_verify_svn2(). So here is my new and improved (and
>> hopefully good) patch. Again, I've only been able to test this on
>> Linux.
>>
>> [[[
>> In cmdline tests, use subprocess.Popen for executing commands to allow
>> support for exit-code checks on both Windows and posix systems. This makes
>> the test suite require Python version >= 2.4.
>>
>>
>
> Ping. Has anyone reviewed the binary_mode changes? Could someone verify
> that the patch works on Windows too?
>

Oh sorry. Looks good to me. I can't test on Windows these days, sorry.

-- Brane

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-04-18 14:56:26 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.