Re: [PATCH] Test cases for deselecting sparse-directories (clean wc)

"Rui, Guo" <timmyguo_at_mail.ustc.edu.cn> writes:
> [[[
> Added test cases for deselecting sparse-directories, currently covering only
> un-modified wc. Marked as XFail until it is properly implemented.
> ...]]]

Guo Rui, those tests were *excellent*, thank you -- exactly what we
needed. I've applied them in r30664, sorry for taking so long to
review.

> There will more test cases for modified wc and updated repos. Any suggestions
> about tricky situations will be appreciated.

Well, there are an infinity of tricky situations. The regression suite
can't cover them all. The basic coverage we have after r30664 is pretty
good; as we make progress issue #2843 we may need to add more tests, but
for now let's concentrate on making the current tests pass.

> PS: I have another test case verifying an example in
> notes/sparse-directories.txt, which is mentioned in my last post. Should I
> post a patch for that?

Yes, definitely!

Thanks,
-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-04-17 19:29:27 CEST