[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r30640 - branches/svnserve-logging/subversion/svnserve

From: Eric Gillespie <epg_at_google.com>
Date: Wed, 16 Apr 2008 13:43:15 -0700

epg_at_tigris.org writes:

> Author: epg
> Date: Wed Apr 16 12:58:09 2008
> New Revision: 30640
> Log:
> Add new kind of log line, where the action starts with "ERR", and log
> such lines when the fs calls our new warning callback. Later, we'll
> use this format to log other things, such as authn/authz failures.
> * subversion/svnserve/serve.c
> (fs_warning_baton_t): Add new baton type.
> (MAX_STRING_LEN): Copy from httpd-2.2.4/include/httpd.h
> (c2x_table, c2x, escape_errorlog_item): Copy from httpd-2.2.4/server/util.c
> (log_fs_warning): Add svn_fs_warning_callback_t function to log the
> svn_error_t object(s), partly based on log_error_core from
> httpd-2.2.4/server/log.c
> (serve): Setup warning callback with svn_fs_set_warning_func

This is bound to be controversial. I suppose the best thing
would be for these facilities to move to apr(-util), but I'm not
sure how interested httpd/apr folks would be in that, not to
mention I have neither the time nor the energy to drive that.

Perhaps the next best thing would be to move these facilities to
a new file in svnserve/ with a copy of the Apache copyright
statement as well as our own?

To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-04-16 22:43:41 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.