Re: svn commit: r30489 - trunk/subversion/svnsync

On Thu, Apr 10, 2008 at 5:50 AM, <cmpilato_at_tigris.org> wrote:
> Author: cmpilato
> Date: Thu Apr 10 05:50:01 2008
> New Revision: 30489
>
> Log:
> Followup to r30482, using the correct path comparison function.
>
> * subversion/svnsync/main.c
> (do_initialize): Use svn_path_is_child() instead of
> svn_path_is_ancestor(), as the latter returns TRUE when the paths
> are equivalent, too.

Thanks! Looks correct to me.

My other worry (about spurious slashes) is unfounded: svnsync uses
svn_opt_args_to_target_array to grab its URLs, and that function
(undocumentedly!) canonicalizes URLs to remove trailing slashes (among
other things).

--dave

> Modified:
> trunk/subversion/svnsync/main.c
>
> Modified: trunk/subversion/svnsync/main.c
> URL: http://svn.collab.net/viewvc/svn/trunk/subversion/svnsync/main.c?pathrev=30489&r1=30488&r2=30489
> ==============================================================================
> --- trunk/subversion/svnsync/main.c Thu Apr 10 05:32:53 2008 (r30488)
> +++ trunk/subversion/svnsync/main.c Thu Apr 10 05:50:01 2008 (r30489)
> @@ -626,7 +626,7 @@ do_initialize(svn_ra_session_t *to_sessi
>
> /* If we're doing a partial replay, we have to check first if the server
> supports this. */
> - if (svn_path_is_ancestor(root_url, baton->from_url))
> + if (svn_path_is_child(root_url, baton->from_url, pool))
> {
> svn_boolean_t server_supports_partial_replay;
> svn_error_t *err = svn_ra_has_capability(from_session,
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: svn-unsubscribe_at_subversion.tigris.org
> For additional commands, e-mail: svn-help_at_subversion.tigris.org
>
>

-- 
David Glasser | glasser@davidglasser.net | http://www.davidglasser.net/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org