[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Svn_wc_set_changelist should clear it's own error (memory leak in +- all implementers of svn_wc_notify_func2) (Issue #3169)

From: Ben Collins-Sussman <sussman_at_red-bean.com>
Date: Thu, 10 Apr 2008 10:28:47 -0500

Care to send a patch?

On Thu, Apr 10, 2008 at 9:03 AM, Bert Huijben <B.Huijben_at_competence.biz> wrote:
> Hi,
>
> svn_wc_set_changelist assumes al implementations of svn_wc_notify_func2
> will clear the err value if it it's notifying its
> svn_wc_notify_changelist_moved event.
>
> In r27073 subversion/svn/notify.c was altered for this specific case.
> But this requirement was not documented at the C api level; and I don't
> think we can break the ABI so that the receiver of the notify (Any
> subversion client, Tortoise, ...) is responsible for releasing the value
> of a field in this specific case.
>
> The releasing of the error should be moved back to the caller to remove
> the api change since 1.4; or a pool cleanup function should be
> registered as is the case in the svn_wc_dup_notify() method.
>
> Bert
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
> For additional commands, e-mail: dev-help_at_subversion.tigris.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-04-10 17:29:01 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.