[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svnsync test failures with 1.4.x svnserve [including a 1.5 release blocker]

From: Lieven Govaerts <svnlgo_at_mobsol.be>
Date: Thu, 10 Apr 2008 10:36:08 +0200

Thanks for the 1.4 compatibility testing Dave!

For the record, the reported issues were fixed.

David Glasser wrote:
> Tests 20 and 22 in svnsync_tests.py fail when used with a 1.4.x svnserve.
> line 56, in run_sync
> raise SVNUnexpectedStderr(errput)
> SVNUnexpectedStderr: ['subversion/libsvn_ra_svn/client.c:858:
> (apr_err=170003)\n', "svnsync: Server doesn't support setting
> arbitrary revision properties during commit\n"]
> FAIL: svnsync_tests.py 20: test copying revprops other than svn:*
> line 56, in run_sync
> raise SVNUnexpectedStderr(errput)
> SVNUnexpectedStderr: ['subversion/libsvn_repos/commit.c:392:
> (apr_err=160016)\n', "svnsync: Path 'trunk' not present\n"]
> FAIL: svnsync_tests.py 22: test syncing subdirectories with changes on root
> It seems like #20 is a serious compatibility problem: the call to
> svn_ra_get_commit_editor3 in svnsync/main.c(replay_rev_started) ought
> to trap SVN_ERR_RA_NOT_IMPLEMENTED and retry with the minimal set of
> props (writing the rest in replay_rev_finished). (Don't forget that
> our claim all along has been that you can even use an svn 1.0
> repository for the destination of svnsync!) I'll use the magic words
> "1.5 blocker" here.

Fixed in r30453, r30462 and r30463
> #22 ought to fail as well... but not for this reason! It ought to
> fail because svnsync checks for partial replay support, except it kind
> of doesn't. r30440 fixes this (making #22 fail for the correct
> reason, in addition to making #21 correctly fail). However, I do note
> that the partial replay check in do_initialize is a little sketchy:
> /* If we're doing a partial replay, we have to check first if the server
> supports this. */
> if (strcmp(root_url, baton->from_url) < 0)
> {
> Won't this treat trying to sync "http://foo/bar/baz/" when
> "http://foo/bar/baz" is the repo root as a partial sync?
Yes, fixed in r30482.


To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-04-10 10:36:25 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.