Re: [PATCH] Use subprocess.Popen for executing commands in cmdline tests

jeremy hinds wrote:
>> * I /think/ i recall that we have the binary-mode parameter for a
>> reason. I don't remember the reason offhand, but just killing off
>> that option doesn't seem safe. (FWIW, the reason is most likely
>> related to text and binary being different on Windows.)
>>
>
> I think you're right, in that the binary-mode param was only used when
> invoking os.popen3() on platforms without the Popen3 class (Windows).
> But having replaced both of those with subprocess.Popen, there's
> nowhere to use that parameter anymore. At least, I don't see anything
> that looks analogous in creationflags or anywhere like that.
>

universal_newlines=True is text (non-binary) mode.

-- Brane

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-04-07 17:19:13 CEST