[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [Patch] RE: Why was svn_client_mergeinfo_get_merged removed?

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: Mon, 07 Apr 2008 10:38:03 -0400

Bert Huijben wrote:
> Here is a patch that reintroduces the svn_client_mergeinfo_get_merged() and
> svn_client_mergeinfo_get_eligible() (former
> svn_client_mergeinfo_get_available()) API's.

I'm not interested in carrying forward a naive implementation of
get_eligible(). Most of the use-cases for that functionality that I'm aware
of are either a) pointless if not paired with additional info (like 'svn
log' output) or b) answerable using the get_merged() API.

> An other change is that svn_client_suggest_merge_sources() started returning
> repository local paths instead of full urls, while the documentation still
> says it should return full urls. (This change was merged to 1.5.x in the
> same merge as the other changes)

Is that true? Looking at the code for this function, there are two places
where the list of returned values is appended to. Both cases are appending
the result of a path-join with the repository root URL and a repos-relative
path. Did some bug suddenly appear there?

C. Michael Pilato <cmpilato_at_collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand

Received on 2008-04-07 16:38:22 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.