[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: don't use assert()

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: Mon, 07 Apr 2008 10:05:28 -0400

Kouhei Sutou wrote:
> It seems that svn_path_is_url(merge_source_url) is failed
> easily by user input... And a program will be crashed and a
> user will see like the following message that is not useful
> for him:
> subversion/libsvn_client/mergeinfo.c:1144: svn_client_mergeinfo_log_merged: Assertion `svn_path_is_url(merge_source_url)' failed.

Right, sure. So the correct thing to do (as I'm getting rather tired of
*assert*ing) is for the command-line client to check the input and print the
nicey nicey error message, leaving the libraries to assert whatever they
wish to assert.

C. Michael Pilato <cmpilato_at_collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand

Received on 2008-04-07 16:05:48 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.