Re: revision number output in 'svn mergeinfo' command

On Sat, Apr 5, 2008 at 7:03 AM, Karl Fogel <kfogel_at_red-bean.com> wrote:
> I have a simple, self-explanatory patch I'd like to apply & backport,
> for consistency in how we present revision numbers. Anyone think this
> is nuts?
>
> [[[
> Brand management: when printing out revision numbers, use the "r" prefix.
>
> * subversion/svn/mergeinfo-cmd.c
> (print_log_rev): Make it so.
> ]]]

The only negative reason I could see is that it makes it epsilon
harder to pipe into a script that does

  log -rREV
  diff -cREV

--dave

> Index: subversion/svn/mergeinfo-cmd.c
> ===================================================================
> --- subversion/svn/mergeinfo-cmd.c (revision 30326)
> +++ subversion/svn/mergeinfo-cmd.c (working copy)
> @@ -43,7 +43,7 @@
> svn_log_entry_t *log_entry,
> apr_pool_t *pool)
> {
> - svn_cmdline_printf(pool, "%ld\n", log_entry->revision);
> + svn_cmdline_printf(pool, "r%ld\n", log_entry->revision);
> return SVN_NO_ERROR;
> }
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
> For additional commands, e-mail: dev-help_at_subversion.tigris.org
>
>

-- 
David Glasser | glasser@davidglasser.net | http://www.davidglasser.net/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org