[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: regression in 1.5 accessing server root

From: Erik Huelsmann <ehuels_at_gmail.com>
Date: Fri, 4 Apr 2008 23:00:32 +0200

On Fri, Apr 4, 2008 at 10:35 PM, Stefan Küng <tortoisesvn_at_gmail.com> wrote:
> Hi,
>
> I've reported this a few hours ago, but it appears that my mail didn't get
> through. So here goes again, but this time with an actual reproduction
> recipe:
>
> set up apache (only tried with https, not http but it shouldn't make a
> difference), use this location block:
>
> <Location />
> DAV svn
> SVNPath D:/Development/repos/test
> AuthType Basic
> AuthName "Subversion repositories"
> AuthUserFile passwd
> Require valid-user
> #AuthzSVNAccessFile conf/svnaccessfile
> </Location>
>
> (my server is running on Vista, svn 1.4.5)
>
> Then, with an 1.4.x client, do
> $ svn co https://server/ workingcopy
>
> it will succeed.
>
> But with an 1.5 client, this doesn't work:
> $ svn co https://server/ workingcopy
> svn: OPTIONS of 'https://server': Could not parse response status line
> (https://server)
>
> Tried both with the 1.5 client from
> http://merge-tracking.open.collab.net/files/documents/147/440/CollabNetSubversion-client-EA-1.5.0-10.win32.exe
> and one built myself from the 1.5.x branch about an hour ago.
> (and of course with TSVN, just in case you're wondering)

Thanks for the report!

For any devs looking at this problem, I believe this patch should fix the issue.

Index: subversion/libsvn_ra_neon/util.c
===================================================================
--- subversion/libsvn_ra_neon/util.c (revision 30292)
+++ subversion/libsvn_ra_neon/util.c (working copy)
@@ -369,7 +369,8 @@
   req->pool = reqpool;
   req->iterpool = svn_pool_create(req->pool);
   req->method = apr_pstrdup(req->pool, method);
- req->url = apr_pstrdup(req->pool, url);
+ req->url = /* If the URL is "", add the root slash */
+ (*url) ? apr_pstrdup(req->pool, url) : "/";
   req->rv = -1;

   /* Neon resources may be NULL on out-of-memory */

Unfortunately, since I didn't test it, I can't commit it, but it
should be giving someone a head start.

Bye,

Erik.
Received on 2008-04-04 23:00:48 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.