Eric Gillespie <epg_at_pretzelnet.org> writes:
>> Yeah, I believe that you *can* add new callbacks; you just can't add
>> new callbacks that must ~always have a non-default implementation.
>
> I'm not sure how well that's going to work out in practice,
> especially with something like the editor interface, but OK. Is
> this what you had in mind?
>
> Index: svn_delta.h
> ===================================================================
> --- svn_delta.h (revision 30158)
> +++ svn_delta.h (working copy)
> @@ -922,6 +922,8 @@
> svn_error_t *(*abort_edit)(void *edit_baton,
> apr_pool_t *pool);
>
> + /* Be sure to update svn_delta_get_cancellation_editor and
> + * svn_delta_default_editor if you add a new callback here. */
> } svn_delta_editor_t;
Yes, with "()"s. Also, we should add something to the main doc string
indicating that one should never allocate these things oneself.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-04-03 06:20:24 CEST