Re: [PATCH] Cancellation editor discards abort_edit

On Wed, Apr 2, 2008 at 6:53 PM, Karl Fogel <kfogel_at_red-bean.com> wrote:
> Eric Gillespie <epg_at_pretzelnet.org> writes:
> > I suppose you meant "svn_delta_default_editor and
> > svn_delta_get_cancellation_editor". But, I'm not sure it helps;
> > you can't add new editor callbacks, you have to create a revved
> > editor interface, complete with new default/cancellation/god only
> > knows what else.
>
> Hmm. I thought we deliberately designed all our structures now to take
> additions at the end, so that old code referring into them would never
> miss. In fact, I thought this was one reason we insist that
> 'svn_delta_editor_t' be allocated by 'svn_delta_default_editor() instead
> of by apr_p[c]alloc() ? (We seem to have neglected to document that,
> but I remember it being The Plan.)
>
> This strategy is obvious with opaque structures, of course, but I
> thought we were doing it for some non-opaque ones too...

Yeah, I believe that you *can* add new callbacks; you just can't add
new callbacks that must ~always have a non-default implementation.

--dave

-- 
David Glasser | glasser@davidglasser.net | http://www.davidglasser.net/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org