Re: [PATCH] Call abort_edit upon editor error in repos reporter

Eric Gillespie <epg_at_pretzelnet.org> writes:
> I thought an entire error chain is always about the same error,
> but each error in the chain is more specific. This is a
> completely unrelated error. It would be very odd to have this
> one reporter to the user as an outermost error.
>
> Indeed, discarding it is the general pattern:
>
> [...]

I surrender.

> Thanks for reviewing these two; I don't hold it against you if
> you skip reviewing the swig-py nastiness ;->. Thing about that
> one is that my local Python expert found a larger reference
> counting issue in that code (which dates back to gstein in 2002!)
> when he revieed my change. I'll bring that one up next.

I did skip the swig-py patch, yes :-). But I'm curious to see about
this ref-counting issue, I'll look for it.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-04-03 03:42:14 CEST