"David Glasser" <glasser_at_davidglasser.net> writes:
> Shouldn't this go in svn_opt?
>
> Also, revkind isn't a term we use; the variable is called
> svn_opt_revision_kind. Perhaps SVN_OPT_REVISION_KIND_DEPENDS_ON_WC?
Oy. The prefix "SVN_OPT_REVISION_KIND_DEPENDS_ON_" is already 32 chars
long. Maybe "SVN_OPT_REVISION_KIND_NEEDS_WC" ?
-Karl
>> * subversion/libsvn_client/log.c
>> (svn_client_log4): Use the new macro. Even if start/end revision kind
>> is dependent on working copy, display an error message.
>>
>> Approved by: kameshj
>>
>> Modified:
>> trunk/subversion/include/svn_client.h
>> trunk/subversion/libsvn_client/log.c
>>
>> Modified: trunk/subversion/include/svn_client.h
>> URL: http://svn.collab.net/viewvc/svn/trunk/subversion/include/svn_client.h?pathrev=29948&r1=29947&r2=29948
>> ==============================================================================
>> --- trunk/subversion/include/svn_client.h Tue Mar 18 21:41:21 2008 (r29947)
>> +++ trunk/subversion/include/svn_client.h Wed Mar 19 05:50:54 2008 (r29948)
>> @@ -4303,6 +4303,16 @@ svn_client_open_ra_session(svn_ra_sessio
>>
>> /** @} */
>>
>> +/** Return TRUE iff revision kind is dependent on the working copy.
>> + * Otherwise, return FALSE.
>> + *
>> + * @since New in 1.6.
>> + */
>
> Since macros don't have types for their arguments, the docstring
> should say the type of the argument (although this probably is
> irrelevant if you change the name to SVN_OPT_REVISION_KIND_foo).
> [
>> +#define SVN_CLIENT_IS_WC_DEPENDENT_REVKIND(kind) \
>> + ((kind == svn_opt_revision_base || kind == svn_opt_revision_previous || \
>> + kind == svn_opt_revision_working || kind == svn_opt_revision_committed) \
>> + ? TRUE : FALSE)
>
> --dave
>
>
> --
> David Glasser | glasser@davidglasser.net | http://www.davidglasser.net/
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: svn-unsubscribe_at_subversion.tigris.org
> For additional commands, e-mail: svn-help_at_subversion.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-04-03 00:17:04 CEST