[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Allow testing of svn client exit codes

From: Branko ─îibej <brane_at_xbc.nu>
Date: Wed, 02 Apr 2008 23:45:15 +0200

jeremy hinds wrote:
> I will be posting an updated patch in a separate email. While working
> on it, I found a couple of things that I wanted to bring up:
>
> 1) In cmdline/svntest/main.py (function: run_one), there is a comment
> that says "don't trust the exitcode [from spawn_process()], will not
> be correct on Windows". Python docs say that wait() is supported on
> Unix only, so this may be the reason. I'll try to dig around for more
> info, but if exit codes cannot be reliably gotten on Windows, must I
> wrap a check against "main.is_posix_os()" around the exit-code
> verification?
>

I think we should move all that code to use the subprocess module. I
know it requires python-2.4, but frankly, I don't care if it makes the
test suite more useful.

I know I've seen our tests report false positives because we weren't
looking at exit codes.

-- Brane

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-04-02 23:45:57 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.