[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] commit-email.pl: support subject line based on log message

From: David Glasser <glasser_at_davidglasser.net>
Date: Mon, 31 Mar 2008 21:35:55 -0700

On Mon, Mar 31, 2008 at 9:25 PM, Gregory Nathan Price <price_at_mit.edu> wrote:
> On Mon, Mar 31, 2008 at 03:39:44PM -0700, David Glasser wrote:
> > 2008/3/28 Gregory Nathan Price <price_at_mit.edu>:
>
> > > [[[
> > > * tools/hook-scripts/commit-email.pl.in
> > > Support --summary for taking subject line from log message.
> > >
> > > Patch by: Greg Price <price_at_mit.edu>
> > > ]]]
> >
>
> > Looks reasonable to me. However, instead of:
> >
> > chop(my $summary = $log[0]);
> >
> > how about
> >
> > my $summary = @log ? $log[0] : '';
> > chop $summary;
> >
> > ?
>
> Sure. New patch attached with this change.
>
> I also switched to chomp per the thread's further discussion, though
> in the present code it makes no difference; from where @log is created
> on line 368, it's clear every element ends with a newline.

Committed in r30151; thanks for the patch! (In the future, try create
your patches at the root of trunk instead of in the subdirectory?)

--dave

-- 
David Glasser | glasser@davidglasser.net | http://www.davidglasser.net/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-04-01 06:36:06 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.