Re: [PATCH] commit-email.pl: support subject line based on log message

2008/3/28 Gregory Nathan Price <price_at_mit.edu>:
> This adds to commit-email.pl a flag --summary,
> which produces subject lines like
> r123 - Stop frobbing the veeblenitzer
> instead of the familiar
> r123 - in src/veeble: . nitzed
> , copying the first line of the log message into the subject line.
>
> [[[
> * tools/hook-scripts/commit-email.pl.in
> Support --summary for taking subject line from log message.
>
> Patch by: Greg Price <price_at_mit.edu>
> ]]]
>
> I've generally preferred this form of subject line in the small
> projects I've worked on, and would be very pleased to get it with
> a flag rather than patching commit-email.pl every time.

Looks reasonable to me. However, instead of:

    chop(my $summary = $log[0]);

how about

    my $summary = @log ? $log[0] : '';
    chop $summary;

?

--dave

-- 
David Glasser | glasser@davidglasser.net | http://www.davidglasser.net/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org