[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] serf backend requires servers category configuration

From: Lieven Govaerts <svnlgo_at_mobsol.be>
Date: Mon, 31 Mar 2008 19:09:59 +0200

Silly question: what does svn do without your patch? Does it crash?
Ignore configuration?

Lieven

Kouhei Sutou wrote:
> Hi,
>
> I found a difference between Neon backend and Serf backend.
>
> Neon backend doesn't require SVN_CONFIG_CATEGORY_SERVERS
> configuration but Serf backend does.
>
> Index: subversion/libsvn_ra_serf/serf.c
> ===================================================================
> --- subversion/libsvn_ra_serf/serf.c (revision 30128)
> +++ subversion/libsvn_ra_serf/serf.c (working copy)
> @@ -374,9 +374,12 @@
> SVN_CONFIG_OPTION_SSL_AUTHORITY_FILES, NULL);
> #endif
>
> - server_group = svn_config_find_group(config,
> - session->repos_url.hostname,
> - SVN_CONFIG_SECTION_GROUPS, pool);
> + if (config)
> + server_group = svn_config_find_group(config,
> + session->repos_url.hostname,
> + SVN_CONFIG_SECTION_GROUPS, pool);
> + else
> + server_group = NULL;
>
> if (server_group)
> {
>
>
> Thanks,
> --
> kou
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
> For additional commands, e-mail: dev-help_at_subversion.tigris.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-03-31 19:10:14 CEST

This is an archived mail posted to the Subversion Dev mailing list.