[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] bug(let) in mod_dav_svn: Cannot navigate from repository top to repository list when SVNListParentPath is on.

From: Jan Nijtmans <nijtmans_at_tigris.org>
Date: Mon, 31 Mar 2008 09:58:59 +0200

2008/3/29, Daniel Shahaf <d.s_at_daniel.shahaf.co.il>:
> Also, please wrap at 79 columns. (See
> http://subversion.tigris.org/hacking.html#coding-style.)

Thank you for all your comments. Here is a new attempt, in which
all given comments are handled.

Log message:
 * subversion/mod_dav_svn/repos.c
   (deliver): Allow browser navigation from repository top to repository list
   when SVNListParentPath is on.

Reproduction recipe.

 - Go with your browser (IE or any other) to the top of any svn repository
 where SVNListParentPath is set to on, e.g.:
 - Note that the super-directory (/plugins/) is browsable as well, but
 you cannot navigate to it from here.
 - I would expect that the first entry of the list is a hyperlinked "..",
 which would navigate to its super-directory.

 I checked this with the trunk and the buglet is still there.

 Rationale: in repos.c, the decision whether to include the link or
 not is based on two things:
 - If repos_path is of length 1 (so it must be "/"), then skip this step
 - If the collection is of type DAV_SVN_RESTYPE_PARENTPATH_COLLECTION
   (the highest browsable directory), then skip this step too.

 This can be fixed by ignoring the first condition when SVNListParentPath is on.
 Unfortunately I don't have an environment set up to build mod_dav_svn to test
 this, but I'm pretty confident that this fix will work (for what's worth).

 Can I file an issue for this? See patch below.

        Jan Nijtmans

 Here is the patch against trunk in unified diff (I re-ordered it a
little because
 dav_svn__get_list_parentpath_flag() is a more expensive test, so it should
 be done last):

To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org

Received on 2008-03-31 09:59:12 CEST

This is an archived mail posted to the Subversion Dev mailing list.