[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH]Can we accept JavaHL Revison.Number.Number(-1)?

From: Kamesh Jayachandran <kamesh_at_collab.net>
Date: Thu, 27 Mar 2008 21:33:57 +0530

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

David Glasser wrote:
> On Thu, Mar 27, 2008 at 2:09 AM, Kamesh Jayachandran <kamesh_at_collab.net> wrote:
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA1
>>
>>
>>
>>
>> David Glasser wrote:
>> > On Wed, Mar 26, 2008 at 7:34 AM, Kamesh Jayachandran <kamesh_at_collab.net> wrote:
>> >> Hi All,
>> >>
>> >> I am working on exposing 'svn_client__get_revision_number' in JavaHL.
>> >>
>> >> I want a equivalent of youngest_rev(in/out param in
>> >> svn_client__get_revision_number method).
>> >>
>> >> Unfortunately our JavaHl does not allow revision numbers to be '-1'.
>> >
>> > I would think that your change would be confusing, since people
>> > familiar with the Subversion API would expect "-1" to be
>> > SVN_INVALID_REVNUM.
>> >
>> > Does the JavaHL API really not use an equivalent of SVN_INVALID_REVNUM anywhere?
>> >
>> > Could you just use null?
>>
>>
>> I can use null, but when I want to use an object as In/Out param it
>> won't be useful. I need Revison.Number.Number(-1) to know that as an Out
>> Param and Revison.Number.Number(ANY_VALID_NUMBER) as an In param.
>
> Ugh, Revision.Number is a mutable type? That strikes me as a poor choice...
>

SVNClient.info2() saves me from getting the desired information so no
need of new JAVAHL API.

With regards
Kamesh Jayachandran

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFH68Vt3WHvyO0YTCwRArmwAJ0R8OLuVOmd3KmqbJgHklItv3iWWgCdGnRO
aULA8Gp86tb89gWzG5Lyo3s=
=L4Zx
-----END PGP SIGNATURE-----

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-03-27 17:04:43 CET

This is an archived mail posted to the Subversion Dev mailing list.