[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: [PATCH]Can we accept JavaHL Revison.Number.Number(-1)?

From: Kamesh Jayachandran <kamesh_at_collab.net>
Date: Wed, 26 Mar 2008 23:18:57 +0530

>Mark Phippard wrote:
>> Maybe the underlying native API you want to call supports this
>> functionality and there are internal cases where it is used or needed,
>> but before we expose this to users via JavaHL I think we should
>> understand why we would want to. I notice the native API is a double
>> underscore, so maybe that is a good sign that it is not correct to
>> expose this as is. Why not just have an API like this that is
>> exposed?
>> /**
>> * Returns the youngest revision number for path.
>> * @since 1.6
>> */
>> public native long getYoungestRevisionNumber(String pathOrUrl);
>> Internally, this could call the native API and hide the other details.

>It would still need to call a public libsvn_client API, since the C++
>layer of the JavaHL bindings only has access to public APIs.

If I understand correctly we can make use functions with '__' in their name from
other svn libraries from JavaHL as we already use such intra library functions
from libsvn_fs_util in libsvn_fs_(fs|base).

With regards
Kamesh Jayachandran
Received on 2008-03-26 18:52:31 CET

This is an archived mail posted to the Subversion Dev mailing list.