[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[Patch] Notify on property changes

From: Bert Huijben <B.Huijben_at_competence.biz>
Date: Wed, 26 Mar 2008 18:07:01 +0100

        Hi,

On IRC:
<Bert> Any reason why svn_client_propset3 never calls the notify method?
(Almost any method that changes the client api that changes the wc
status calls notify.. except setproperty)
<Bert> In AnkhSVN I collect all paths notified to the notifier and mark
them dirty (to be svn status'ed later)
<Bert> But I miss the property setters
<Bert> And it is quite expensive to re-check all changes with most depth
values
<Bert> Would a patch on that be accepted? Shouldn't be that hard to
write I suppose
<hwright> Bert: It seems reasonable to me.
<hwright> but I don't remember if there was a conscious decision to go
with the current route.
<Bert> I don't think it would be really usefull for svn; but I think it
might be usefull for other bindings.. And with depth and changelists
added in 1.5 working around it gets pretty complicated
<hwright> I'd say go for it!

[[
Make svn_client_propset3 call notify on all updated paths

* subversion/include/svn_wc.h
  (svn_wc_notify_action_t): Add new enum
'svn_wc_notify_property_updated'

* subversion/libsvn_client/prop_commands.c
  (propset_walk_baton): Added notify_func and notify_batton
  (propset_walk_cb): Call notify on all updated paths
  (svn_client_propset3): Initialize notify_func and notify_batton from
   The client context

Patch by: Bert Huijben <b.huijben_at_competence.biz>
]]

In the patch I fixed a few very minor doxygen whitespace and @since
issues on svn_wc_notify_action_t.

        Bert

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-03-26 18:07:14 CET

This is an archived mail posted to the Subversion Dev mailing list.