[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Oddity in r29895 (ra_serf error handling tweak).

From: Lieven Govaerts <svnlgo_at_mobsol.be>
Date: Sat, 22 Mar 2008 08:31:14 +0100

Karl Fogel wrote:
> r29895 contains this patch:
>
> --- subversion/libsvn_ra_serf/update.c (revision 29894)
> +++ subversion/libsvn_ra_serf/update.c (revision 29895)
> @@ -2293,6 +2293,12 @@
> }
> if (status)
> {
> + svn_error_t *err = parser_ctx->error;
> +
> + if (err)
> + svn_error_clear(sess->pending_error);
> +
> + SVN_ERR(parser_ctx->error);
> SVN_ERR(sess->pending_error);
> [...]
>
> Is there some reason to declare the new 'err' variable? Why not just
> do:
>
> if (parser_ctx->error)
> svn_error_clear(sess->pending_error);

No real reason, fixed in r30001. Thx.

Lieven

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-03-22 08:30:54 CET

This is an archived mail posted to the Subversion Dev mailing list.