[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: SVN 1.5 - Beta 1 - mkdir behavior

From: Karl Heinz Marbaise <khmarbaise_at_gmx.de>
Date: Wed, 19 Mar 2008 13:07:29 +0100

Hi there,

thanks for the fast response....

> Yes, this is definitely a bug. And the following is, I think, the fix:
>
> Index: subversion/libsvn_client/add.c
> ===================================================================
> --- subversion/libsvn_client/add.c (revision 29944)
> +++ subversion/libsvn_client/add.c (working copy)
> @@ -34,6 +34,8 @@
> #include "svn_io.h"
> #include "svn_config.h"
> #include "svn_props.h"
> +#include "svn_hash.h"
> +#include "svn_sorts.h"
> #include "client.h"
>
> #include "svn_private_config.h"
> @@ -636,6 +638,7 @@
> const char *log_msg;
> apr_hash_t *revprop_table;
> apr_array_header_t *targets;
> + apr_hash_t *targets_hash;
> svn_error_t *err;
> const char *common;
> int i;
> @@ -667,6 +670,8 @@
>
> /* Condense our list of mkdir targets. */
> SVN_ERR(svn_path_condense_targets(&common, &targets, urls, FALSE,
> pool));
> + SVN_ERR(svn_hash_from_cstring_keys(&targets_hash, targets, pool));
> + SVN_ERR(svn_hash_keys(&targets, targets_hash, pool));
>
> if (! targets->nelts)
> {
> @@ -702,6 +707,8 @@
> }
> }
> }
> + qsort(targets->elts, targets->nelts, targets->elt_size,
> + svn_sort_compare_paths);
>
> /* Create new commit items and add them to the array. */
> if (SVN_CLIENT__HAS_LOG_MSG_FUNC(ctx))
>
>> By the way, why isn't the '-p' short option available for this command?
>
> Because we are very protective of our short option namespace.
>
I have patched my installed SVN 1.5-beta1 version and rechecked the
behavior and it worked fine.

Thanks.

Kind regards
Karl Heinz Marbaise

-- 
SoftwareEntwicklung Beratung Schulung    Tel.: +49 (0) 2405 / 415 893
Dipl.Ing.(FH) Karl Heinz Marbaise        ICQ#: 135949029
Hauptstrasse 177                         USt.IdNr: DE191347579
52146 W├╝rselen                           http://www.soebes.de
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-03-19 13:08:05 CET

This is an archived mail posted to the Subversion Dev mailing list.