[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Branch 1.5.x: mod_dav_svn restricts third-party Subversion clients too much.

From: Alexander Kitaev <Alexander.Kitaev_at_svnkit.com>
Date: Fri, 14 Mar 2008 19:17:50 +0100


There is the following code in subversion/mod_dav_svn/repos.c:1643

     if (val && (ap_strstr_c(val, "SVN/") == val))
         repos->is_svn_client = TRUE;

         /* Client capabilities are self-reported. There is no
            guarantee the client actually has the capabilities it says
            it has, we just assume it is in the client's interests to
            report accurately. Also, we only remember the capabilities
            the server cares about (even though the client may send
            more than that). */

SVNKit honestly sends "SVNKit ..." User-Agent header and as a result
capabilities reported by SVNKit are ignored by mod_dav_svn. Could the
condition above be changed to:

     if (val && (ap_strstr_c(val, "SVN") == val))

So far we have to use SVN/Kit for User-Agent HTTP header value.

Alexander Kitaev,
TMate Software,
http://svnkit.com/ - Java [Sub]Versioning Library!
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-03-14 19:18:52 CET

This is an archived mail posted to the Subversion Dev mailing list.