[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r29753 - in trunk/subversion/tests/cmdline: . svntest

From: Senthil Kumaran S <senthil_at_collab.net>
Date: Fri, 07 Mar 2008 19:23:05 +0530

Senthil Kumaran S wrote:
> julianfoad_at_tigris.org wrote:
>> - # now try to unlock with user jconstant, should fail.
>> + # now try to unlock with user jconstant, should fail but exit 0.
>> if sbox.repo_url.startswith("http"):
>> expected_err = ".*403 Forbidden.*"
>> else:
>> expected_err = "svn: warning: User '%s' is trying to use a lock
>> owned by "\
>> "'%s'.*" % (svntest.main.wc_author2,
>> svntest.main.wc_author)
>> - svntest.actions.run_and_verify_svn(None, [], expected_err, 'unlock',
>> - '--username',
>> svntest.main.wc_author2,
>> - pi_path)
>> + svntest.actions.run_and_verify_svn2(None, [], expected_err, 0,
>> + 'unlock',
>> + '--username',
>> svntest.main.wc_author2,
>> + pi_path)
>
> Same here too. When we have "403" from http it is a failed request and
> the exit code must be 1.

My previous patch fails for svnserveautocheck. Updated patch attached (passes
in all layers). Again, would like to hear whether my inference is correct,
before I commit.

[[[
Fix lock_test failure in dav.

* subversion/tests/cmdline/lock_tests.py
   (unlock_wrong_token, unlocked_lock_of_other_user): fix test failure due
    to wrong exit code expectation for http errors.

Patch by: stylesen
]]]

-- 
Senthil Kumaran S
http://www.stylesen.org/


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org

Received on 2008-03-07 14:53:19 CET

This is an archived mail posted to the Subversion Dev mailing list.