[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: $Header$ keyword support

From: Karl Fogel <kfogel_at_red-bean.com>
Date: Wed, 05 Mar 2008 22:09:19 -0500

"Nathan Hamilton" <nehamilton_at_gmail.com> writes:
> In regards to the patch submitted by Alexander L. Belikoff here:
>
> http://svn.haxx.se/dev/archive-2004-07/0876.shtml
>
> As I understand it, the patch was eventually rejected due to the
> change to the (now deprecated) svn_subst_keywords_t struct and the
> compatibility issues that it would have caused.. I'm curious though
> as to why support for 'Header' was not added soon after the change to
> the keywords API (r16171). Using the svn_subst_build_keywords2
> function, I believe the change can now be made to allow newer versions
> of Subversion to recognize and substitute the 'Header' keyword while
> older versions will continue to ignore it (and not cause any API
> issues).
>
> I am currently tasked with doing a CVS to Subversion migration that
> relies heavily on this keyword. I can only speak for myself, but I
> think it would be positive to have one less potential hurdle that CVS
> administrators have to consider when looking at moving to Subversion.
>
> I wanted to post here to find out if there were any objections to
> adding this functionality. If not, I would be happy to submit an
> updated patch for it.

I think this makes sense. And there shouldn't be any compatibility
issues as far as legacy files go, since no 'svn:keywords' properties
currently in the wild should have "header" as one of their values.

Consider this an expression of interest. I'm only speaking for
myself, but I admit it's hard to imagine anyone vetoing it, since it's
safe compatibility-wise, not likely to complicate the code, and serves
a useful purpose.

-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-03-06 04:09:30 CET

This is an archived mail posted to the Subversion Dev mailing list.