[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] consistent function formatting for libsvn_ra

From: Branko ─îibej <brane_at_xbc.nu>
Date: Mon, 03 Mar 2008 20:33:54 +0100

Karl Fogel wrote:
> Stefan Sperling <stsp_at_elego.de> writes:
>
>> If blame information is really that important, we should scratch the
>> patch altogether. Otherwise I'd still rather opt for consistent style.
>>
>> I stumbled across this because Steve is looking into adding code to
>> one of the files in question, and we could not figure out the correct
>> style to use for new code.
>>
>> So I asked in IRC what style new code should use. Erik Huelsmann said
>> the project was aiming at keeping the style consistent within modules.
>> Since libsvn_ra's style is totally ambiguous, I created the patch to
>> make it consistent.
>>
>> So, for me, it's not about being tidy for the sake of it, but because
>> of the benefits consistency provides when adding or modying code.
>>
>
> I think consistency is worth it too. Maybe apply this after 1.5 is
> released?
>

... after which there will be no more backports?

"A foolish consistency" etc. I vote we leave well enough alone.

-- Brane

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-03-03 20:34:46 CET

This is an archived mail posted to the Subversion Dev mailing list.