[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r29672 - trunk/subversion/svn

From: Lieven Govaerts <svnlgo_at_mobsol.be>
Date: Mon, 03 Mar 2008 18:06:46 +0100

cmpilato_at_tigris.org wrote:
> Author: cmpilato
> Date: Mon Mar 3 08:46:44 2008
> New Revision: 29672
>
> Log:
> Finish issue #3108 by raising an error for 'svn cl FOO' or svn cl
> --remove' (with no explicit target path).
>
> NOTE: I'm not sure I fully agree with this course of action, but I
> don't disagree enough stand in the way of correcting the general UI
> problem of running a command only to see nothing happening.
>
> * subversion/svn/changelist-cmd.c
> (svn_cl__changelist): Don't add the implicit dot target; instead,
> error if no paths are provided.
>

Hm. I'm not in favor of this change.

After r29671 the output of changelist is:

$ svn cl blabla
Skipped '.'

I think this makes perfect sense, as we use the same notification to
indicate lack of directory support in changelist.

If in the future we add dir support, do we still want the user to
provide the explicit '.' target? I'd think not, as we don't expect it
for most of the other commands.

So now we have two different ways to tell the user that directories are
not supported, either by the 'Skipped' notification, or with this
exception. I find this is more confusing than helpful.

Lieven

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-03-03 18:06:33 CET

This is an archived mail posted to the Subversion Dev mailing list.