[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r29617 - trunk/subversion/svn

From: Karl Fogel <kfogel_at_red-bean.com>
Date: Fri, 29 Feb 2008 19:46:54 -0500

"David Glasser" <glasser_at_davidglasser.net> writes:
> You can't do this in the definition itself, I think (after all, gotta
> name them variables), but you could (for static functions, say) insert
> a declaration immediately before the declaration:
>
> static svn_foo_func_t best_foo_ever;
> static svn_error_t
> best_foo_ever(svn_foo_t x, apr_pool_t *y)
> {
> }

Yeah. That's sort of like remembering to write the comment (which
we're supposed to do already, but sometimes forget) saying "/* This
implements the svn_foo interface. */".

But still, having the type in the header file is an improvement, and
using an actual type-check is no harder to remember than a comment,
for static functions.

+1

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-03-01 01:47:15 CET

This is an archived mail posted to the Subversion Dev mailing list.