[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] consistent out-of-date handling by commit

From: Karl Fogel <kfogel_at_red-bean.com>
Date: Fri, 29 Feb 2008 18:13:18 -0500

Arfrever Frehtes Taifersar Arahesis <arfrever.fta_at_gmail.com> writes:
> 2008-02-29 17:43:05 Stephen Butler napisaƂ(a):
>> Index: subversion/libsvn_client/commit_util.c
>> ===================================================================
>> --- subversion/libsvn_client/commit_util.c (revision 29632)
>> +++ subversion/libsvn_client/commit_util.c (working copy)
>> ...
>> + "not found" error appears during the delta transmisssion. */
>
> "transmisssion"

If you liked the patch other than that, it's okay to commit and just
fix the typo as part of the commit.

Not that there's anything wrong with pointing out a typo, of course!
But for a contributor, it can be a bit dispiriting to post a complex
patch and have the sole response be a one-line mail pointing out a
typo in a comment :-). So when we do that, we try to say also "Sorry
I didn't have time to look at the rest of the patch, I just noticed
this typo" or "I committed it in rXXXXX, with just a typo fix."

-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-03-01 00:13:32 CET

This is an archived mail posted to the Subversion Dev mailing list.