[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Issue #3108: "svn changelist clname" does nothin

From: Daniel Shahaf <d.s_at_daniel.shahaf.co.il>
Date: Fri, 29 Feb 2008 19:08:03 +0200 (Jerusalem Standard Time)

Daniel Shahaf wrote on Wed, 27 Feb 2008 at 18:07 +0200:
> David Glasser wrote on Tue, 26 Feb 2008 at 15:34 -0800:
>> On Tue, Feb 26, 2008 at 3:16 PM, Daniel Shahaf <d.s_at_daniel.shahaf.co.il>
>> wrote:
>>> David Glasser wrote on Tue, 26 Feb 2008 at 13:10 -0800:
>>> > Hmm. I kind of feel like "svn changelist" should default to
>>> > svn_depth_infinite rather than svn_depth_empty. Then (a) "svn cl new
>>> > --cl old" lets you do a rename, without need an extra "-R"
>>>
>>> I think svn_depth_empty would be a better default if dirs can be members
>>> of changelists (otherwise, every changelist-operation on the dir applies
>>> to its children too). I agree svn_depth_infinite is a better default if
>>> dirs cannot be members of changelists.
>>
>> They can't be at the moment.
>>
>> I'm OK with, if a future version decides to allow directories on
>> changelists, making people use "svn cl --depth=empty name dir" to put
>> the directory on it (or -N).
>>
...
>>> > (If this change doesn't happen, perhaps a warning (ie, notification)
>>> > that a directory is being skipped would be useful.)
>>> >
>>>
>>> +1 (moral support).
>>>
>
> I will prepare a new patch, then, implementing 'svn_depth_infinite' as
> default and 'skip' notifications.
>

Two patches attached, implementing:

* 'svn cl': default to 'svn_depth_infinity'
* 'svn cl': generate 'skip' notifications on directories [1]

The three patches (these two and the one I just posted elsethread)
should be mutually independent, and I believe they can be applied in
any order, but I have not tested them separately.

[1] Notes on the "'skip' notifications" patch:

   * I added infrastructure to changelist_tests:1 to parse 'skip' output,
     but it is not used yet.

Daniel

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org

Received on 2008-02-29 23:05:41 CET

This is an archived mail posted to the Subversion Dev mailing list.