[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Issue #3108: "svn changelist clname" does nothin

From: David Glasser <glasser_at_davidglasser.net>
Date: Tue, 26 Feb 2008 13:10:31 -0800

2008/2/23 Daniel Shahaf <d.s_at_daniel.shahaf.co.il>:
> [[[
> Fix issue #3108: "svn changelist clname" does nothing.
>
> * subversion/svn/changelist-cmd.c
> (svn_cl__changelist):
> Require --changelist or an explicit path argument.
>
> * subversion/tests/cmdline/changelist_tests.py
> (changelist_without_arguments): New test.
> (test_list): Run it.
> ]]]
>
> The new test doesn't intend to check that changelist renaming ('svn cl
> foo --cl bar') works correctly---only that it is syntactically allowed.

Um, and when you say "the new test doesn't intend to check", you also
mean "with this patch, svn cl foo --cl bar still does nothing", right?
 (Because that's what I'm seeing, and it's kind of unfortunately.)

Hmm. I kind of feel like "svn changelist" should default to
svn_depth_infinite rather than svn_depth_empty. Then (a) "svn cl new
--cl old" lets you do a rename, without need an extra "-R" and (b)
"svn cl clname directory" will add the directory's recursive contents
to clname instead of just doing *nothing*.

(If this change doesn't happen, perhaps a warning (ie, notification)
that a directory is being skipped would be useful.)

--dave

-- 
David Glasser | glasser@davidglasser.net | http://www.davidglasser.net/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-02-26 22:10:44 CET

This is an archived mail posted to the Subversion Dev mailing list.