Re: [PATCH] Allow testing of svn client exit codes

jeremy hinds wrote:
>> I wonder -- would this be better done by changing the existing
>> run_and_verify_svn(), adding an optional expected_exit parameter? We could
>> document that when some expected error output is provided, this parameter
>> defaults to 1 (or whatever EXIT_FAILURE is), otherwise it defaults to 0
>> (EXIT_SUCCESS), but of course callers can pass in the expected value of
>> their choosing. Might be a good way to retroactively check all our existing
>> test paths against expected exit values.
>
> This does sound like a better approach, but I wasn't sure if it would
> work with the existing function signature:
>
> def run_and_verify_svn(message, expected_stdout, expected_stderr, *varargs):
>
> AFAICT, an optional expected_exit parameter would have to come before
> varargs, and would therefore become effectively required, since the
> varargs are always present. Am I missing something?

Well, that's a bummer. I didn't actually check the signature before making
my suggestion, unfortunately. :-(

-- 
C. Michael Pilato <cmpilato_at_collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org