[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] consistent function formatting for libsvn_ra

From: Stefan Sperling <stsp_at_elego.de>
Date: Tue, 26 Feb 2008 01:24:51 +0100

On Mon, Feb 25, 2008 at 02:21:03PM -0800, Blair Zajac wrote:
> Also, I think it would be best of hold off on whitespace and formatting
> changes until 1.5 is released.

Agreed, delaying this until after 1.5 release to keep diffs concise
while a lot of backporting is still being done might be a good idea.

On Mon, Feb 25, 2008 at 05:52:38PM -0500, Karl Fogel wrote:
> I'm not sure the blame-information loss is worth a bit of extra tidiness.

Mmmh. Good point also.

If blame information is really that important, we should scratch the
patch altogether. Otherwise I'd still rather opt for consistent style.

I stumbled across this because Steve is looking into adding code to
one of the files in question, and we could not figure out the correct
style to use for new code.

So I asked in IRC what style new code should use. Erik Huelsmann said
the project was aiming at keeping the style consistent within modules.
Since libsvn_ra's style is totally ambiguous, I created the patch to
make it consistent.

So, for me, it's not about being tidy for the sake of it, but because
of the benefits consistency provides when adding or modying code.

-- 
Stefan Sperling <stsp_at_elego.de>                 Software Developer
elego Software Solutions GmbH                            HRB 77719
Gustav-Meyer-Allee 25, Gebaeude 12        Tel:  +49 30 23 45 86 96 
13355 Berlin                              Fax:  +49 30 23 45 86 95
http://www.elego.de                 Geschaeftsfuehrer: Olaf Wagner

  • application/pgp-signature attachment: stored
Received on 2008-02-26 01:25:06 CET

This is an archived mail posted to the Subversion Dev mailing list.