jeremy hinds wrote:
> I am hoping to take a crack at issue 3097 (exit non-zero when running
> `svn pg` on an unset property) in the near future. And there are a
> few similar exit-code issues in there. So I thought a good place to
> start is with the ability to test this sort of thing.
>
> I don't know if exit codes are as interesting for the other binaries,
> so this patch only deals with the client. And since I am still trying
> to familiarize myself with the conventions, and I'm no Python expert,
> please let me know what I can do to make this better.
I wonder -- would this be better done by changing the existing
run_and_verify_svn(), adding an optional expected_exit parameter? We could
document that when some expected error output is provided, this parameter
defaults to 1 (or whatever EXIT_FAILURE is), otherwise it defaults to 0
(EXIT_SUCCESS), but of course callers can pass in the expected value of
their choosing. Might be a good way to retroactively check all our existing
test paths against expected exit values.
--
C. Michael Pilato <cmpilato_at_collab.net>
CollabNet <> www.collab.net <> Distributed Development On Demand
Received on 2008-02-25 14:12:05 CET